-
Notifications
You must be signed in to change notification settings - Fork 4k
docs(firebase_analytics): example app initialization and docs support status #7745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Visit the preview URL for this PR (updated for commit a34cc44): https://flutter-firebase-docs--pr7745-analytics-example-uc6ihq0q.web.app (expires Wed, 12 Jan 2022 13:25:14 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small changes from me. I think you'll also need to add back in the google service file for example/android as well.
Co-authored-by: Russell Wheatley <[email protected]>
Co-authored-by: Russell Wheatley <[email protected]>
Co-authored-by: Russell Wheatley <[email protected]>
Is the PR title correct here? It says fix but only applies docs and examples changes so shouldn't change versions of anything? |
yes I agree, |
Description
Fixed the initialization part in the example app for firebase_analytics and addd the support status section to show which plugins/platforms currently doesn't support the Dart-only initialization.
Related Issues
closes #7639
closes #7543
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).melos run analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?